Skip to content

remarks

⚠️ DRAFT ⚠️

i wanted to have a look at the code, on the WIP branch. the code will likely change in the meantime, so this issue will have to be revised, but let's go anyway:

  • pin the Rust version (rust-toolchain.toml#L2)
  • add rust-analyzer to the components of the toolchain (components = ["rust-analyzer"])
  • without examples nor tests, i don't see the use of the rng module
  • run cargo check, cargo fmt and cargo clippy
  • can't we just use rs_merkle directly instead of implementing the commit module

💡 Note

yeah, i have to admit i have some trouble understanding the rng and commit modules 😕

i'll leave the rest of the code for now, it looks not totally ready 😃

Edited by STEVAN Antoine